chore: Remove anvil from auto layout owners by znamenskii-ilia · Pull Request #36246 · appsmithorg/appsmith

znamenskii-ilia · 2024-09-11T07:50:24Z

Description

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.ImportExport"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10825604667
Commit: ff8c8e4
Cypress dashboard.
Tags: @tag.ImportExport
Spec:

Thu, 12 Sep 2024 07:00:18 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Chores
- Updated ownership assignments for various directories and files to streamline team responsibilities.
- Removed broader ownership categories to clarify specific areas managed by the anvil-team.

coderabbitai · 2024-09-11T07:50:33Z

Walkthrough

The pull request modifies the CODEOWNERS file to update the ownership assignments for specific directories and files within the application. It removes several paths from the ownership of the @appsmithorg/anvil-team, while adding a more focused path for the layoutSystems/anvil directory. This restructuring indicates a refinement in team responsibilities regarding code management.

Changes

Change Type	File/Path Summary
Removed	`app/client/src/actions/autoHeightActions.ts`
Removed	`app/client/src/actions/autoLayoutActions.ts`
Removed	`app/client/src/layoutSystems/*`
Added	`app/client/src/layoutSystems/anvil/*`
Removed	`app/client/src/sagas/autoHeightSagas/*`
Removed	`app/client/src/selectors/autoHeightSelectors.ts`
Removed	`app/client/src/selectors/autoLayoutSelectors.tsx`
Removed	`app/client/src/utils/autoHeight/*`
Removed	`app/client/src/utils/hooks/autoHeightUIHooks.ts`

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AnvilTeam as @appsmithorg/anvil-team
    participant LayoutSystems

    User->>AnvilTeam: Request changes
    AnvilTeam->>LayoutSystems: Update ownership
    LayoutSystems-->>AnvilTeam: Confirm changes
    AnvilTeam-->>User: Notify completion

Poem

In the realm of code, a shift takes flight,
Paths redefined, responsibilities bright.
Anvil's team, with focus anew,
Streamlined their roles, as they always do.
Ownership clear, like stars in the night,
Guiding their way, with purpose and light! ✨

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bc59bd1 and ff8c8e4.

Files selected for processing (1)

CODEOWNERS (2 hunks)

Files skipped from review due to trivial changes (1)

CODEOWNERS

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

KelvinOm · 2024-09-11T08:50:01Z

CODEOWNERS


 # UI Builders Pod
 app/client/generators/* @appsmithorg/anvil-team
-app/client/src/actions/autoHeightActions.ts @appsmithorg/anvil-team


But someone has to own this, right? @riodeuno WDYT?

@KelvinOm Tagging @somangshu. The widgets pod can own this. This particular feature is related to Fixed mode, however, it is a core feature and not a widget feature. Owners of Widget Development API should own this.

## Description Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.ImportExport" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10825604667> > Commit: ff8c8e4 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10825604667&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.ImportExport` > Spec: > <hr>Thu, 12 Sep 2024 07:00:18 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **Chores** - Updated ownership assignments for various directories and files to streamline team responsibilities. - Removed broader ownership categories to clarify specific areas managed by the `anvil-team`.

remove anvil from auto layout owners

ff8c8e4

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 11, 2024

znamenskii-ilia requested review from KelvinOm and jsartisan September 11, 2024 07:51

KelvinOm reviewed Sep 11, 2024

View reviewed changes

KelvinOm approved these changes Sep 11, 2024

View reviewed changes

znamenskii-ilia added the ok-to-test Required label for CI label Sep 11, 2024

sagar-qa007 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Sep 12, 2024

znamenskii-ilia merged commit 9706602 into release Sep 12, 2024

znamenskii-ilia deleted the chore/update-codeowners-2 branch September 12, 2024 07:18

coderabbitai bot mentioned this pull request Feb 26, 2025

fix:codeowners file #39447

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Remove anvil from auto layout owners#36246

chore: Remove anvil from auto layout owners#36246
znamenskii-ilia merged 1 commit intoreleasefrom
chore/update-codeowners-2

znamenskii-ilia commented Sep 11, 2024 •

edited by github-actions bot

Loading

Uh oh!

coderabbitai bot commented Sep 11, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

KelvinOm Sep 11, 2024

Uh oh!

riodeuno Sep 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

znamenskii-ilia commented Sep 11, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

KelvinOm Sep 11, 2024

Choose a reason for hiding this comment

Uh oh!

riodeuno Sep 11, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

znamenskii-ilia commented Sep 11, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Sep 11, 2024 •

edited

Loading